Try mode #112
Merged
Try mode #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alanshaw when you get a chance please confirm this works for you. thanks! 👍 |
|
LGTM - the tests in my application pass with 5.1.0, fail with 5.1.1 and pass again using this branch. |
|
@alanshaw thanks for confirming that, are you happy for us to 🚢 this branch as the new version of the plugin? |
|
Please do! |
|
Done! |
|
Shipped. |
|
plz check your gitter messages |
|
@alanshaw sec report filed. thanks for the advice. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds regression test for
tryandoptionalauth modes.see: #111
Without the lines:
it actually works exactly as expected.
Confirmed by the master in: hapijs/hapi#2843
@alanshaw I took the regression tests directly from your branch: alanshaw@736067f
please
checkoutthis branch and confirm it works as expected.Thanks. 👍